search

willir / cargo-ndk-android-gradle

Cargo NDK for Android projects
Apache License 2.0
55 stars 7 forks source link

Doesn't automatically detect cdylib targets #8

Closed joshyrobot closed 3 years ago

joshyrobot commented 3 years ago

As of right now, the code seemingly only automatically copies dylib targets: https://github.com/willir/cargo-ndk-android-gradle/blob/ec87de2ab8e27cb2792848d6c7a9a1e509fc5a5c/plugin/src/main/groovy/com/github/willir/rust/CargoNdkBuildTask.groovy#L135-L137 I don't really know what the difference is, but the jni crate docs say to use cdylib, so I think it'd make sense to detect both: https://docs.rs/jni/0.18.0/jni/#the-rust-side

willir commented 3 years ago

Thanks for reporting the issue. Could you check the 0.3.2 version? It should have the fix.

joshyrobot commented 3 years ago

Works perfectly! Thank you!