search

willis-meyers / artgallery

1 stars 0 forks source link

Looks good across different OS, mobile, and browsers! #10

Open willis-meyers opened 8 years ago

willis-meyers commented 8 years ago

@koreoliver @SofyaMulenok

Update - I applied the fixes we discussed last night. They were pushed in increments instead of in bulk so we can parse through what was changed easily. Checkout aggregatespace.com/hackbright

Looks good on PC/MAC OSX/IE/iOS/Android -- woot!

Minor changes from here. Shout out if you have questions about my commits.

SofyaMulenok commented 8 years ago

Looks great!! Awesome job!

koreoliver commented 8 years ago

Yay! Good job! It looks awesome!

SofyaMulenok commented 8 years ago

I made a few tiny changes to the scraper css, now with Willis's changes it looks the way I envisioned it :+1: I made the images scale smaller, so that there's less brokenness in some of the rare very long titles (plus it looks a bit more consistent with the archive section that way). Excited for tomorrow!

willis-meyers commented 8 years ago

Whoops! Reverting changes here in a minute as we had a merge conflict. I had it setup to look the following pic, so reverting since adjusting length of title/description isn't an option tonight. Thanks for adjusting the readme too - looks great. We could even reference that for our presentation tomorrow.

screen shot 2015-10-13 at 5 23 22 pm
SofyaMulenok commented 8 years ago

That looks good! Thank you :)

2015-10-13 17:27 GMT-07:00 S. Willis Meyers notifications@github.com:

Whoops! Reverting changes here in a minute as we had a merge conflict. I had it setup to look the following pic, so reverting since adjusting length of title/description isn't an option tonight. Thanks for adjusting the readme too - looks great. We could even reference that for our presentation tomorrow. [image: screen shot 2015-10-13 at 5 23 22 pm] https://cloud.githubusercontent.com/assets/13667306/10471935/80023318-71cf-11e5-9bd5-298be84149ee.png

— Reply to this email directly or view it on GitHub https://github.com/willis-meyers/artgallery/issues/10#issuecomment-147891076 .

koreoliver commented 8 years ago

Very nice @willis-meyers and @SofyaMulenok! Everything looks great!