willkg / crashstats-tools

Command line tools and library for interacting with Crash Stats (https://crash-stats.mozilla.org/)
Mozilla Public License 2.0
7 stars 0 forks source link

include today's crash reports in supersearchfacet #136

Closed willkg closed 2 months ago

willkg commented 2 months ago

The end-date is up-to-but-not-including and defaults to "today".

$ supersearchfacet --_facets=platform --verbose
No API token provided. Set CRASHSTATS_API_TOKEN in the environment.
Skipping dumps and protected data.
Params: {'_facets': ['platform'], 'date': ['>=2024-06-19', '<2024-06-26']}
supersearch_facet: url: https://crash-stats.mozilla.org/api/SuperSearch/, params: {'_facets': ['platform'], 'date': 
['>=2024-06-19', '<2024-06-26'], '_results_number': 0}
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): crash-stats.mozilla.org:443
DEBUG:urllib3.connectionpool:https://crash-stats.mozilla.org:443 "GET /api/SuperSearch/?_facets=platform&date=%3E%3D2024-06-19&date=%3C2024-06-26&_results_number=0 HTTP/1.1" 200 258
platform
 platform   | count  
------------|--------
 Windows NT | 367453 
 Android    | 156094 
 Linux      | 35939  
 Mac OS X   | 23389  
 Unknown    | 11869  
 total      | 594744 

That's fine, except when using supersearch and supersearchfacet against a local dev environment with crash reports from today, the crash reports don't come up by default and it's mildly onerous to make sure to include today.

We should adjust the code so that start_date is pinned to 00:00:00 when no time is specified and end_date is pinned to 23:59:59 when no time is specified and maybe support a "yesterday" option in case someone doesn't want partial day results.