search

willkg / ernest

DEAD PROJECT: I'm always frank and earnest with bugs. Uh, in GitHub I'm Frank, and Bugzilla I'm Ernest.
Mozilla Public License 2.0
6 stars 4 forks source link

Ordering for Status field seems arbitrary #72

Open rik opened 9 years ago

rik commented 9 years ago

ASSIGNED and PRs are mixed. While fixing this, instead of an alphabetical order, I'd like to have them ordered by order of "completion" so NEW -> ASSIGNED -> PR-.

screen shot 2015-01-12 at 14 53 51

willkg commented 9 years ago

I'm not entirely sure what this screenshot is showing. It doesn't appear to be in alphabetical order by status.

I think that sort code is here:

https://github.com/willkg/ernest/blob/1237dd3a0b92699d06719a47d5b241e97d58d15f/ernest/static/js/controllers.js#L136

I don't think I'm going to get to fixing this anytime soon, so if someone else wants to take a stab at it, please do.

rik commented 9 years ago

Sorry if the screenshot is confusing, I opted for "file quickly" to not forget to file it. This is from https://sumo-ernest.herokuapp.com/project/buddyup/bu-2015-1. Currently, I can see some PRs, then some ASSIGNED, then some PRs then NEW and then CLOSED. So it's not by alphabetical order but not in any order that I can identify either.

mythmon commented 9 years ago

I would imagine this is because the table is sorted only by Bugzilla status, and then the PR listing overlays that field. The "Status" field is really showing two columns worth of data, but only sorting by one of them. This sounds like a good thing to fix.