search

willm / DDEXUI

A user interface for creating simplified ddex metadata
GNU General Public License v2.0
31 stars 18 forks source link

Python27 #19

Open flavianh opened 9 years ago

flavianh commented 9 years ago

Hello,

I wanted to test your module, but I mostly use python 27 so I've done a bit of work to make it compatible. Could you check if it works fine in python 3+?

willm commented 9 years ago

Hey, @traxair that looks really cool. TBH I took the opportunity of starting this project to teach myself python. I assumed it was best to start by learning python 3, but it seems that most of the community is still using python 2, so that may have been a mistake!

It looks like there are a lot of line ending differences in the pull request, could you convert them to the same as the source line endings so that it's easier to see the edits? I'll try to run the tests on python 3 in the next few days.

flavianh commented 9 years ago

What line ending do you use? My setup is the eclipse / git default, so it should be CRLF

flavianh commented 9 years ago

BTW I can't find your email, could we chat about how this library could be made compatible for reading DDEX files as well?

flavianh commented 9 years ago

OK, Eclipse's default is CRLF, and then Git converts this to LF, which usually works fine with other repositories I participate in. LF is more "unix", so it would make sense to choose this one (who needs 2 newline characters?)