willmcgugan / codereviews

Free code reviews for open source projects
113 stars 3 forks source link

Code review for `marker` #27

Open mustafaquraish opened 2 years ago

mustafaquraish commented 2 years ago

What is the name of your project? marker

What is the repo URL? https://github.com/mustafaquraish/marker

Is there anything else I should know about the code?

Are there any areas you would like me to focus on? General API design, I'd like to have different interfaces to use the same core code, for instance I have a CLI with rich+cmd2, and a web-interface (link for reference). Currently a lot of the interface between the core code and the "frontend" is done through the console class defined in my code, which seems very hacky.

Have I reviewed this project previously? No