willmcpo / body-scroll-lock

Body scroll locking that just works with everything 😏
MIT License
4.04k stars 337 forks source link

Doesn't work fine for 'iphone x' #129

Open alexanderLanars opened 5 years ago

alexanderLanars commented 5 years ago

For see this problem you need:

  1. Get Iphone X, open https://bodyscrolllock.now.sh/
  2. Little scroll page to top, for hide bottom panel with navigation buttons
  3. Slick 'disable body scroll'
  4. Swipe page in the same place, where was bottom panel with nav buttons
  5. As you can see, page still scrolled
hacknug commented 5 years ago

You mean it doesn't stay at the same place when you force Safari to show its bars?

alexanderLanars commented 5 years ago

No, I mean, when you hide Safari bottom bar and touch and swipe on that place (where was bar), you can scroll page.

hacknug commented 5 years ago

Can't reproduce on iOS 13. It only covers some content that was visible when the bars were hidden.

KayLeung commented 5 years ago

I ran into this problem.

This is only happening on Safari. Because when you swipe from the bottom, it calling the bottom bar out. (On fast swiping, the body will scroll) Bad iOS behaviors!

hacknug commented 5 years ago

Just managed to trigger scroll in both directions when double tapping the top/bottom of the viewport (not by dragging the page up and down like you'd usually do to scroll). This was on the latest iOS 13 beta.

diachedelic commented 5 years ago

This is an old article concerning the "special" status of page areas where the menu bars sit: https://benfrain.com/the-ios-safari-menu-bar-is-hostile-to-web-apps-discuss/