search

willmcpo / body-scroll-lock

Body scroll locking that just works with everything 😏
MIT License
4.04k stars 337 forks source link

Support scrolling on both axes (iOS) #133

Open xanido opened 4 years ago

xanido commented 4 years ago

Currently, enabling bodyScrollLock disables scrolling on anything but the targetElement. However, on iOS, it also locks scrolling to the Y axis, preventing horizontal scrolling on the targetElement.

This PR allows scrolling on either axis on the targetElement.

kubmir commented 4 years ago

@willmcpo Hello, how does it look with this PR? Will it be released? I would like to use horizontal scrolling. Thanks for the answer.

Aarbel commented 4 years ago

@willmcpo please help 🙏

Aarbel commented 4 years ago

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally.

Have you tested this case ?

Aarbel commented 4 years ago

Moreover @xanido looks like @willmcpo works in Qantas company in Sydney, so if you want to target him directly to update this repo, you're very close

willmcpo commented 4 years ago

Hi all, will look into this PR soon

Aarbel commented 4 years ago

Thanks a lot @willmcpo, sorry again for the multiple pings

Aarbel commented 4 years ago

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally.

Have you tested this case ?

@willmcpo i think you should also check this

drosi94 commented 3 years ago

Hey people! is this PR going to be merged soon? I really need this so maybe I need to implement it by myself it it's not going to be merged. Thank you!

willmcpo commented 3 years ago

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally. Have you tested this case ?

@willmcpo i think you should also check this

is this still an issue?