iOS Safari 13 - Githubissues

willmcpo / body-scroll-lock

Body scroll locking that just works with everything 😏

MIT License

4.04k stars 337 forks source link

iOS Safari 13 #134

Closed gbruzzo closed 4 years ago

gbruzzo commented 4 years ago

Hi everyone,

we just did a little testing on a site on which we had installed bodyscrolllock: it seems that iOS 13 Safari (and therefore all webkit based browsers) finally

acknowledge overflow:hidden;
ignore webkit-overflow-scrolling: touch;

could someone please confirm?

Cheers

hazzo commented 4 years ago

I think you are right, library is actually not working on iOS13

joeldbirch commented 4 years ago

~~For me, it seems to correctly prevent body scroll, but also prevents scrolling within other elements, too.~~ The above was due to attempting to scroll the child of the element I called the directive on, which is incorrect. Thanks to @carpben for mentioning it in this issue.

gempir commented 4 years ago

FYI. The overflow hidden on the body is still not respected in all cases (like when the minimal safari UI is on)

diachedelic commented 4 years ago

iOS 13 support added with #155