fix: add px to positional css values for ios devices

willmcpo / body-scroll-lock

Body scroll locking that just works with everything 😏

MIT License

4.04k stars 338 forks source link

fix: add px to positional css values for ios devices #228

Closed mindnektar closed 2 years ago

mindnektar commented 2 years ago

Fixes #182

lincolnthree commented 2 years ago

That would do it. Lol :) Nice catch.

BwamNL commented 2 years ago

Agree!

efimweb commented 2 years ago

@willmcpo could you approve it please?

efimweb commented 2 years ago

@willmcpo could you publish it to npm?

sdennett55 commented 2 years ago

@willmcpo i'll give you $10 if you publish this to npm.

lincolnthree commented 2 years ago

This PR still has another bug:

line 130

Same problem, needs + 'px' added as a suffix.

owenhoskins commented 2 years ago

This fixed my https://github.com/willmcpo/body-scroll-lock/issues/182 for me. Would be handy to have this on NPM. Currently using it via "body-scroll-lock": "https://github.com/willmcpo/body-scroll-lock#79c4cf2c956eb7d5cf8d54a03d12751bc6ac8aa3" in my package.json