search

willn / go_meals_scheduling

Great Oak Meals Scheduling
MIT License
0 stars 1 forks source link

re-visit survey session preferences (non-dates) aren't being saved #3

Closed willn closed 5 years ago

willn commented 6 years ago

After having saved the survey, re-visiting the survey fails to pull up the previously saved preferences, making it easy to lose them when re-saving.

willn commented 6 years ago

The user complained that she had selected "no" on the question about cleaning after doing a cooking shift, but I didn't see that "no" saved in her preferences. After some discussion, we figured that the "no" preference may have been lost after she revisited the survey multiple times.

I just tested many times and found that upon multiple revisits, some with making changes and others without... that I never lost the "no" preference.

At this point, I can only believe that she had checked that option and then forgot to hit save. Since those details are lost to the sands of time. Since I can't replicate the bug, I can't "fix" anything.

willn commented 5 years ago

This is more edge-casey than I thought. This user has the following:

  1. 1 name selected for "Avoid scheduling with"
  2. "Avoid cleaning the same day as cooking" selected
  3. comments
  4. 2 Weekday Meal cleaner (6 meals/instance) & 3 Weekday asst cook (3 meals/instance)
  5. Mixture of avoid and OK

When attempting to save, I can't get both 1 and 3 at the same time. I could add a name in 1, but only if I don't add new comments.

willn commented 5 years ago

I found that I could leave the comment "x" and it would save. However, if I entered "a'", then the comments would not save.

willn commented 5 years ago

Fixed with PDO quote. Added provideGetSaveRequestsSQL unit test to cover this.