search

willow-ahrens / Finch.jl

Sparse tensors in Julia and more! Datastructure-driven array programing language.
http://willowahrens.io/Finch.jl/
MIT License
158 stars 15 forks source link

Create a conversion function from fiber to vector-of-tuples #426

Closed kylebd99 closed 6 months ago

kylebd99 commented 6 months ago

Per the title.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (25afb3f) 75.84% compared to head (1ef52fb) 75.73%.

Files Patch % Lines
src/tensors/fibers.jl 14.28% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #426 +/- ## ========================================== - Coverage 75.84% 75.73% -0.12% ========================================== Files 87 87 Lines 7710 7722 +12 ========================================== Hits 5848 5848 - Misses 1862 1874 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

willow-ahrens commented 6 months ago

Thanks for the PR! Summarizing our discussion today, let's convert this into documentation PR for some of the functions in https://github.com/willow-ahrens/Finch.jl/blob/main/src/interface/fsparse.jl, as well as countstored, nnz, dropdefaults, and perhaps some of the sparseArray conversions.

willow-ahrens commented 6 months ago

@kylebd99 I'm closing this PR as we already have the ffindnz functionality, and I'll add an issue for the documentation request. Thanks for your help with this!

willow-ahrens commented 6 months ago

The issue is here: https://github.com/willow-ahrens/Finch.jl/issues/228