search

willow-ahrens / Finch.jl

Sparse tensors in Julia and more! Datastructure-driven array programing language.
http://willowahrens.io/Finch.jl/
MIT License
158 stars 15 forks source link

Small fix to fsparse_impl #442

Closed kylebd99 closed 6 months ago

kylebd99 commented 6 months ago

In the previous implementation, there was a small bug which resulted in incorrectly sorted index vectors. This was because the reverse that happens on line 35 isn't re-reversed latter on.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.03%. Comparing base (0fc4d56) to head (f89f037).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #442 +/- ## ========================================== + Coverage 75.92% 76.03% +0.11% ========================================== Files 89 89 Lines 8299 8300 +1 ========================================== + Hits 6301 6311 +10 + Misses 1998 1989 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

willow-ahrens commented 6 months ago

Awesome, thanks for the fix! I hope it's not too much to ask to add one small test that demonstrates the fix (so I don't break it again) to test_issues.jl?

kylebd99 commented 6 months ago

Of course, just added the test case that was giving me trouble!