search

willow-ahrens / Finch.jl

Sparse tensors in Julia and more! Datastructure-driven array programing language.
http://willowahrens.io/Finch.jl/
MIT License
157 stars 15 forks source link

Fix sparsehash level follow #463

Closed kylebd99 closed 5 months ago

kylebd99 commented 5 months ago

Currently the follow protocol throws an error for sparsehashlevel. I think that this level may be deprecated anyways, but the new level (SparseDict?) doesn't support follow yet.

The fix is very simple, I just added "my_key = freshen(ctx.code, tag, :_key)" to line 415. All other line changes are just formatting white space.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.87%. Comparing base (426bf50) to head (319b057).

Files Patch % Lines
src/tensors/levels/sparsehashlevels.jl 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #463 +/- ## ========================================== + Coverage 75.67% 75.87% +0.20% ========================================== Files 92 92 Lines 8792 8800 +8 ========================================== + Hits 6653 6677 +24 + Misses 2139 2123 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

willow-ahrens commented 5 months ago

Quick question, does your editor adjust whitespace? I see a lot of newline whitespace changes