Closed mtsokol closed 5 months ago
I suspect the test failure is due to FInch deciding to drop dims and julia deciding not to drop dims. I like dropping dims better, idk, but we may want to fix stuff in the future to be julia-compliant. For now, your fix is good.
Exactly - CI should be green now. Could you make a new release once we merge it? Then in finch-tensor
I should have elem-wise and reduction ops running for eager and lazy mode.
Note to myself, and what you mentioned last week - I need to revisit handling scalars. Should there be a Tensor(scalar)
or should we keep it as just Julia/numpy scalars?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.27%. Comparing base (
20d4276
) to head (fba82b4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you bump the version?—WillowOn Mar 18, 2024, at 3:45 PM, Mateusz Sokół @.***> wrote: Exactly - CI should be green now. Could you make a new release once we merge it? Then in finch-tensor I should have elem-wise and reduction ops running for eager and lazy mode. Note to myself, and what you mentioned last week - I need to revisit handling scalars. Should there be a Tensor(scalar) or should we keep it as just Julia/numpy scalars?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
Issue #474
Hi @willow-ahrens,
This PR contains support for
tensordot
andreduce
operations forSwizzleArrays
.Should
FiberOrBroadcast
be renamed to also indicate that is considersSwizzleArrays
?