search

willow-ahrens / Finch.jl

Sparse tensors in Julia and more! Datastructure-driven array programing language.
http://willowahrens.io/Finch.jl/
MIT License
152 stars 13 forks source link

Kbd-wrapperize-fix #547

Closed kylebd99 closed 2 months ago

kylebd99 commented 2 months ago

Fixes issue @546 .

willow-ahrens commented 2 months ago

Okay, I've made my fixes. I thought I would need to call getval somewhere else in that file but I didn't. That's because the rules for other wrappers like offset don't need to inspect the literal values, they just wrap them in call nodes.

willow-ahrens commented 2 months ago

There's still a fair amount of uncovered code in wrapperize.jl, but this PR is a strict improvement so we'll merge it. i think we need to start pushing for more code coverage though.