search

willowisp01 / pe

0 stars 0 forks source link

Unable to add certain (legitimate!) names #10

Open willowisp01 opened 4 months ago

willowisp01 commented 4 months ago

Certain legitimate names do involve the usage of non alphanumerical characters (e.g. A s/o B). It's not possible to add such users to your address book!

Steps to replicate:

  1. Add someone with name A s/o B to the address book

image.png

nus-se-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Client name requirements are too restrictive

Currently client name requirements are too restrictive as they only allow for alphanumeric characters and spaces. This means that some common name formats, especially in Singapore, will not be accepted.

For instance, 's/o' or 'd/o' are common for names of Singaporeans who are Indian. However, the application doesnt accept this as a valid name

Steps to reproduce:

  1. add --name=Theodore Koo s/o Charles --phone=98001715 --email=theodore@example.com --addr=Prince Street, Block 144, #19-14 --tags=Disabled --note=Lactose Intolerant

Resultant output: Screenshot 2024-04-19 at 4.36.36 PM.png

[original: nus-cs2103-AY2324S2/pe-interim#1801] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

There is a work-around which is to save the full name in the notes. image.png

Another work-around is to say "son of" or "daughter of" instead of "s/o" or "d/o".

This enhancement is of lower priority than what we had planned for in V1.4 as it would've altered the behavior of the application during the feature freeze period.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I think being able to add your _legal name_ to the address book should definitely be a most basic functionality. I shouldn't have to use a workaround just to enter my own name.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I think being able to add your _legal name_ to the address book should definitely be a most basic functionality. I shouldn't have to use a workaround just to enter my own name. Hence it would be good if you could fix this ASAP.