willowisp01 / pe

0 stars 0 forks source link

Multiple --tags allowed for edit command #11

Open willowisp01 opened 5 months ago

willowisp01 commented 5 months ago

The command edit should only take in --tags once, as per the user guide. The current implementation, however, allows multiple --tags to be entered, which might lead to contradictory behaviour (such as when I leave both --tag empty, it does not remove the data.)

Examples:

edit 1 --tags=3 --tags=4 (this should not work, but it does)

image.png

edit 1 --tags=3 --tags= (should this remove the tags or not?)

It would be good to check that only one --tag is allowed.

nus-pe-bot commented 5 months ago

Team's Response

02AC2C43-05FF-4C7E-849E-449C0DE8D691.png

edit 1 --tags=3 --tags=

This command will not be allowed, as shown in the screenshot above.

Our user guide states very clearly throughout how this command should be used.

edit 1 --tags=3 --tags=4 (this should not work, but it does)

This command literally should work, as mentioned and demonstrated countless times throughout our user guide.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]