search

willowtreeapps / Hyperion-Android

App Debugging & Inspection Tool for Android
MIT License
1.95k stars 144 forks source link

Public API for closing the drawer #177

Closed Jawnnypoo closed 5 years ago

Jawnnypoo commented 5 years ago

Title says it! We are using Hyperion-Simple-Item and wanted to close the drawer on selection of this item.

ToxicBakery commented 5 years ago

Should these actions be returning a boolean to indicate success or failure of the request?

Jawnnypoo commented 5 years ago

Interesting, yes, that probably is a good idea. Would you like me to update the PR to include that for both open and close?

ToxicBakery commented 5 years ago

I don't have the authority to require it for the PR but as a user of the library, I would appreciate the ability to determine when a request was successful.

Jawnnypoo commented 5 years ago

Updated!

Jawnnypoo commented 5 years ago

Fixed!

Jawnnypoo commented 5 years ago

Thanks for merging! Are you all planning on doing a 0.9.28 release sometime soon? Would appreciate it 🙏

Kritarie commented 5 years ago

Yeah, I'm thinking we'll do one more release on 0.9.x before migrating to androidx for 1.0.0-RC. In the meantime, you can use the SNAPSHOT artifacts to get the latest from develop

Jawnnypoo commented 5 years ago

Sounds good 👍 Might be a good idea to migrate to AndroidX before making a 1.0.0 since that would require a 2.0.0 potentially