search

willowtreeapps / Hyperion-Android

App Debugging & Inspection Tool for Android
MIT License
1.95k stars 144 forks source link

Upgrade to Android X #199

Closed ber4444 closed 3 years ago

ber4444 commented 4 years ago

Getting

Cannot drop Jetifier due to following external dependencies:

* com.willowtreeapps.hyperion:hyperion-core:0.9.27

with the plugin described here: https://adambennett.dev/2020/08/disabling-jetifier/

irgaly commented 4 years ago

I'd like to disable jetifier too. In my project, hyperion is only library using legacy support libraries now.

artur-borowiec commented 4 years ago

A pull request with AndroidX migration has been opened since May 2019, it seems stuck

irgaly commented 4 years ago

related PR link #176

ToxicBakery commented 4 years ago

This is resolved by #209 pending artifact release

irgaly commented 3 years ago

It shows that 0.9.29 has com.android.support:appcompat-v7 dependency in my project.

this is ./gradlew :app:dependencies result with no enableJetifier option.

...
 |    +--- com.willowtreeapps.hyperion:hyperion-core:0.9.29
 |    |    +--- com.willowtreeapps.hyperion:hyperion-plugin:0.9.29
 |    |    +--- com.android.support:appcompat-v7:27.1.1
 |    |    |    +--- com.android.support:support-annotations:27.1.1
 |    |    |    +--- com.android.support:support-core-utils:27.1.1
 |    |    |    |    +--- com.android.support:support-annotations:27.1.1
 |    |    |    |    \--- com.android.support:support-compat:27.1.1
 |    |    |    |         +--- com.android.support:support-annotations:27.1.1
 |    |    |    |         \--- android.arch.lifecycle:runtime:1.1.0
 |    |    |    |              +--- android.arch.lifecycle:common:1.1.0
...

Is it my mistake...?

koral-- commented 3 years ago

v 0.9.29 was released before related PRs are merged. We need to wait for the nearest release.

kuFEAR commented 3 years ago

Hi, it's good point to release only with the upgrading to androidx

nishtahir commented 3 years ago

@ber4444 @koral-- @kuFEAR, You don't necessarily have to wait for the release to go out to migrate. SNAPSHOT builds are published frequently and I encourage pulling that until the next release is available. Instructions are available here https://github.com/willowtreeapps/Hyperion-Android#download

ber4444 commented 3 years ago

snapshots are good for hobby projects but not for enterprise - since they can randomly change

TylerMcCraw commented 3 years ago

@nishtahir there is no snapshot build available as far as I can tell that includes the actual fix implemented in #176 So there is no workaround until someone publishes a build with this fix.

nishtahir commented 3 years ago

Thanks to everyone that helped push this through. 0.9.30 went out a few days ago and should have these fixes.

TylerMcCraw commented 3 years ago

Thanks, @nishtahir Really appreciate y'all and your work on Hyperion.