willowtreeapps / android-instant-apps-demo

Apache License 2.0
108 stars 9 forks source link

Dagger Component dependency handling #3

Open joreilly opened 7 years ago

joreilly commented 7 years ago

Hi,

Not exactly an issue but wasn't sure where to ask this :) Have you created any variations of this where you use dagger component dependencies (or sub components) across the feature/base modules? Right now it seems that the specified @Singleton scope is only applicable for for component for particular feature module (I'm having issue right now as I'm dynamically creating FirebaseApp instance in dagger module and need there to be only one across whole app)....this is probably applicable to any case where multiple dagger components are used but am wondering if anything special needs to be done for Instant Apps as well.

Thanks!