search

willowtreeapps / assertk

assertions for kotlin inspired by assertj
MIT License
760 stars 85 forks source link

Configure languageVersion via toolchain #447

Closed Goooler closed 1 year ago

Goooler commented 1 year ago

Follow up #439.

https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support

JakeWharton commented 1 year ago

I believe this forces the installation of JDK 8 whereas mine will cross-compile using any available JDK.

Goooler commented 1 year ago

Yeah, I noticed only JDK 16 was used on CI, we can add more JDKs if necessary.

JakeWharton commented 1 year ago

I would prefer not to land something like this, as the host JDK version should not matter since they can all cross-compile. We just need an appropriate minimum.

Goooler commented 1 year ago

Alright.