willowtreeapps / conductor-mobile

Conductor Mobile is a port of the Conductor Web Framework for iOS and Android
Apache License 2.0
6 stars 5 forks source link

Optimize isPresentWait #118

Closed mrk-han closed 5 years ago

mrk-han commented 5 years ago

The default implementation of isPresentWait uses waitForCondition, which uses configuration.getTimeout() for the parameter long timeOutInSeconds.

However, this is not immediately obvious or noted in a Javadoc for isPresentWait.

Furthermore, isPresentWait also ties its retries to configuration.getRetries

This is problematic because of the ambiguity in naming of timeout and retries. See: https://github.com/willowtreeapps/conductor-mobile/issues/10