willowtreeapps / cordux

https://willowtreeapps.github.io/cordux/
MIT License
61 stars 4 forks source link

Add support for routing to presenting popover modals #29

Open ianterrell opened 7 years ago

ianterrell commented 7 years ago

Popover modals need to have a source view to be attached to.

Currently, a popover could be well managed by routing within a custom coordinator that has all of the route sent to it. However, in the case of something embedded in the NavigationControllerMetaCoordinator, it will not see any additional routing information. One solution could be to improve the NavigationControllerMetaCoordinator so that it becomes smarter about what segments of the route might get sent to each coordinator in it, so that custom code could manage the popover inside it.

However, PresentingCoordinator could also potentially be extended to handle popover modals; in that way the NavigationControllerMetaCoordinator can be wrapped in a PresentingCoordinator (as it is currently in our app for regular modals).