willowtreeapps / sign-in-with-apple-button-android

An Android library for Sign In with Apple
MIT License
283 stars 68 forks source link

Extract webview code into a DialogFragment #23

Closed evant closed 5 years ago

evant commented 5 years ago

Because displaying the webview in using a dialog directly, it'll dismiss itself on a configuration change. (ex: you rotate the device). Think it would be better to have a custom DialogFragment that handles the webview stuff which is shown when you click on the button.

kconner commented 5 years ago

I reproduce this bug.