search

willowtreeapps / sign-in-with-apple-button-android

An Android library for Sign In with Apple
MIT License
283 stars 68 forks source link

Feature: lower Android SDK requirement #35

Closed necavit closed 5 years ago

necavit commented 5 years ago

Closes #33

kconner commented 5 years ago

The lintRelease task is failing because the FrameLayout constructor we're using in a super call is unavailable before API 21. This change would fix it:

class SignInWithAppleButton @JvmOverloads constructor(
    context: Context,
    attrs: AttributeSet? = null,
    defStyleAttr: Int = 0
) : FrameLayout(context, attrs, defStyleAttr) {
necavit commented 5 years ago

Oops! Ok, I'll add it tomorrow when I am back at the office :)

kconner commented 5 years ago

Thank you!