search

willowtreeapps / sign-in-with-apple-button-android

An Android library for Sign In with Apple
MIT License
283 stars 68 forks source link

Seperate out service logic from button #41

Closed evant closed 5 years ago

evant commented 5 years ago

The button no longer has any special logic in it, allowing you to use any button if you want. This is what I was thinking with https://github.com/willowtreeapps/sign-in-with-apple-button-android/issues/26.

Ended up changing a bit of naming, let me know what you think!

kconner commented 5 years ago

On the whole I think modularity here is a good idea, and we can keep it just as simple to use in the default case.

It occurred to me that we could make the button entirely optional by making the service a core library and the button an addition, but that wouldn't side strongly enough with users. We want to encourage Android developers to do what the HIG says because it's the most recognizable thing for users, so the HIG-themed button will remain at the center of the library.