search

willowtreeapps / sign-in-with-apple-button-android

An Android library for Sign In with Apple
MIT License
283 stars 68 forks source link

Use ripples for buttons instead of selector states #46

Open evant opened 5 years ago

kconner commented 5 years ago

In my opinion the ripple needs to be optional, defaulting to the original coloring behavior.

evant commented 5 years ago

In my opinion the original behavior really doesn't look great with it jumping between colors. Would you be more receptive to a simple fade in? That should be easy to do with selectors.

kconner commented 5 years ago

Yes, fading between white and gray would be preferable in fact. I've got a screen capture movie of the iOS button fading on touch that I'll try and send you tomorrow.

evant commented 5 years ago

https://github.com/willowtreeapps/sign-in-with-apple-button-android/pull/48