willowtreeapps / sign-in-with-apple-button-android

An Android library for Sign In with Apple
MIT License
283 stars 68 forks source link

Fix for the problem 'response_mode must be form_post when name or email scope is requested.' #51

Closed johncodeos closed 4 years ago

johncodeos commented 4 years ago

'response_mode' added as parameter to fix the problem 'response_mode must be form_post when name or email scope is requested.' when you use the scope 'email' or 'name'

I tested it, and it works!

j-duggirala commented 4 years ago

Can you get details using form_post. if we use form_post we cannot get code in query params! so it might not work!

zarksalman commented 4 years ago

By using pull request # 51, I logged in the webview and redirect to my page but did not get any response in the listener. here is my code ` SignInWithAppleConfiguration configuration = new SignInWithAppleConfiguration.Builder() .clientId("my_id") .redirectUri("my_redirect_uri") .scope("name") .build();

   SignInWithAppleCallback callback = new SignInWithAppleCallback() {
        @Override
        public void onSignInWithAppleSuccess(@NonNull String authorizationCode) {
            Log.d("SAMPLE_APP", "Received authorization code from Apple Sign In " + 
            authorizationCode);
        }

        @Override
        public void onSignInWithAppleFailure(@NonNull Throwable error) {
            Log.d("SAMPLE_APP", "Received error from Apple Sign In " + error.getMessage());
        }

        @Override
        public void onSignInWithAppleCancel() {
            Log.d("SAMPLE_APP", "User canceled Apple Sign In");
        }
    };

    appleLoginButton.setUpSignInWithAppleOnClick(getSupportFragmentManager(), configuration, callback); `