willowtreeapps / vocable-ios

Vocable AAC for iOS - Empowering people to communicate with care takers and loved ones.
https://vocable.app
MIT License
78 stars 20 forks source link

#666 | Fix doublespeak bug #691

Closed moyerr closed 2 years ago

moyerr commented 2 years ago

Closes #666

This bug fixes an issue where the first phrase spoken in any category would be spoken twice (only reproduces if you select via head-gaze)

Testing Notes

This PR touches some code in the CarouselGridCollectionViewController, which controls the paging functionality throughout the home screen of the app. Please pay special attention to the following area while testing, to ensure we catch any possible regressions:

rhsalas3 commented 2 years ago

I started on develop and was able to reproduce the errant behavior. From there I switched over to this PR branch and confirmed the fixed behavior with the areas of emphasis that Robbie stressed. Everything looks good. I didn't find any bugs, using head-gaze or touch, for phrase selection via switching categories or pages w/in a category. I also tested out the pagination on the Categories list and Category Details > Edit Phrases screens. I'm confident that this is a good fix.

Devices I used for testing: