willowtreeapps / wombats-api

Wombats API
https://github.com/willowtreeapps/wombats-documentation
MIT License
10 stars 4 forks source link

Keys for Controlled Release #325

Closed morganduverney closed 7 years ago

morganduverney commented 7 years ago

BEFORE SUBMITTING AN ISSUE CHECK THE FOLLOWING:

FEATURE REQUEST

A feature request constitutes any feature not currently supported by the API / Game Engine that does not fall under a Game Play Request.

- Describe the feature you would like to see. Create a key that would allow exclusive access to wombats.io

- Why you believe this would improve the quality of the Wombat's API / Game Engine. We need a way to prevent carte blanche access to wombats.io. A way to do this would be to share keys with selected users that allows access.

- Provide details on expected behavior. Need to discuss what this will look like.

emilyseibert commented 7 years ago

What are keys

Flow

emilyseibert commented 7 years ago

Will need to be able to accept a new key name and create in db

oconn commented 7 years ago

Acceptance Criteria: Users cannot log in without using an access key. If an access key is used they can log in as normal

morganduverney commented 7 years ago

At a high-level, this appears to be working as expected. I'd love to test to make sure the limit works as expected, i.e. when 100 people have used the key, we get an error message (or something) that the key is invalid. @oconn what do you think?

morganduverney commented 7 years ago

Tested and determined that I can log in with an expired access key. Could also log in using an access key that already had max number of users. Kicking back to fix validation.

morganduverney commented 7 years ago

Woooo this is fixed! Closing.