willowtreeapps / wombats-api

Wombats API
https://github.com/willowtreeapps/wombats-documentation
MIT License
10 stars 4 forks source link

Added dev-ddb to build.boot, updated building documentation #404

Closed elibosley closed 7 years ago

elibosley commented 7 years ago

Ready for a PR?

elibosley commented 7 years ago

@dehli This should be good to go, and patches a couple of minor issues

elibosley commented 7 years ago

@dehli This should be good to go!

dehli commented 7 years ago

Actually, one last suggestion would be to create a function that figures out the config file and use that in build.boot (since that logic is currently duplicated).

elibosley commented 7 years ago

@dehli It's currently duplicated because one of the functions has those extra log items - would you still de-duplicate them?

dehli commented 7 years ago

Yep. You can still accomplish logging by doing something like:

(let [config-file (get-config-file)]
  (if config-file
    (log/info (str "Using private config-file " config-file)
    (log/info "Not using a private config-file"))
  config-file)