[Enhancement] Access key error is shown only after login workflow has completed

[morganduverney]

BEFORE SUBMITTING AN ISSUE CHECK THE FOLLOWING:

• [x] I checked existing issues.
• [x] This is not a support question (which can be answered on Slack).
• [x] This issue is on the web client (not API, Lambda, or Bots)

ISSUE DESCRIPTION

- What version of the project are you using? Alpha1 - QA

- What browser and its version are you using? Chrome 56.0.2924.87 (64-bit)

- What did you do? (Steps to Replicate Issue)

1. Make sure that you are logged out of Github
2. On the landing page, click on "Get Started Now" without entering an access code -> No error is shown. The user is navigated to Github login.
3. Log in through Github to be redirected back to the landing page -> Error is shown asking the user to enter a correct access key

- What did you expect to see? Error should be shown before the user attempts to log in through Github

- What did you see instead? Error is shown only after login workflow is complete

- More details? This could be a frustrating experience for a new user

[dehli]

This isn't a bug b/c it's impossible for us to know who they are before they authenticate with Github. We have no way of knowing whether they are a user or not until they signin through Github (and then we can kick them out for having an invalid key if they're not already a member of Wombats).

Sound right @oconn @emilyseibert ?

[morganduverney]

Couldn't we prevent them from clicking "Start Playing Now" if, at minimum, they don't enter a key? Also, if the user already has access with a key, shouldn't they log in through the "Log In" link?

[dehli]

Ya, we could prevent them from clicking "Start Playing Now". And I guess we could check that the key is valid, and if so forward them to Github authentication. We'll have to think about what that will look like as it will change the workflow of signin.