willowtreeapps / wombats-web-client

Web Client for Wombats

https://github.com/willowtreeapps/wombats-documentation

MIT License

4 stars 2 forks source link

Bug/aspect ratio #347

Closed elibosley closed 7 years ago

elibosley commented 7 years ago

PR for #345 .

PR Status

HOLD UNTIL PR #344 MERGED

Ready for PR?

[x] I have updated the CHANGELOG with an entry including a description, a link to my profile, and a link to the issue ticket. This change is filed under an Enhancement or Bug Fix, is shown under the relevant release tag name, and is included in my PR branch.
[x] I have run lein run-lint to check for linting errors.

Changes Proposed:

Arena size set using a ratio to fix display issues

@emilyseibert @oconn @dehli

dehli commented 7 years ago

Could you pull develop into this?

elibosley commented 7 years ago

Pulled! 🙃

elibosley commented 7 years ago

@dehli Check this out 🚀

I wasn't able to get the correct properties from the watcher but I succeeded in fixing the problem using add-watch - let me know if there's something you'd do differently!

dehli commented 7 years ago

Could you resolve the conflicts?

elibosley commented 7 years ago

Fixed conflicts!

elibosley commented 7 years ago

I think this is a lot better, let me know what you think!