Open elibosley opened 7 years ago
What's the reasoning for still having the two for loops?
@dehli the draw arena method is still being used - I haven't depreciated it yet so the dual loops are still used for rendering the game-play, not the simulator.
@dehli What's the status with this PR? If you get a chance to review this in the next few weeks, I'd be more than happy to update the code and make sure everything is good to go!
Hey @elibosley! It's on my backlog. I will get around to this either this weekend, or sometime next week! Hope you had a good week! 😄
Awesome! Thanks, I had a great week! 😆
Ugh so I'm finally getting around to this and having crazy setup issues with Ubuntu - hopefully I can figure out what's wrong with my configuration but I just figured I'd update you about it!
Sounds good! @elibosley Let me know if you need anything!
@dehli Should I fork this repo to push my commit back up? I've updated the code a bit but I'm not sure how I should get it back into a PR
Hey @elibosley! You can just push directly to this branch and it will update the PR appropriately 😄
PR for #274 .
PR Status
IN DEVELOPMENT
Ready for PR?
lein run-lint
to check for linting errors.Changes Proposed:
-
-
Breaking changes?
-
-
Screenshot of feature:
@emilyseibert @oconn @dehli