willowtreeapps / wombats-web-client

Web Client for Wombats
https://github.com/willowtreeapps/wombats-documentation
MIT License
4 stars 2 forks source link

WIP: Feature/wombat animation #361

Open elibosley opened 7 years ago

elibosley commented 7 years ago

PR for #274 .

PR Status

IN DEVELOPMENT

Ready for PR?

Changes Proposed:

-

-

Breaking changes?

-

-

Screenshot of feature:

@emilyseibert @oconn @dehli

dehli commented 7 years ago

What's the reasoning for still having the two for loops?

elibosley commented 7 years ago

@dehli the draw arena method is still being used - I haven't depreciated it yet so the dual loops are still used for rendering the game-play, not the simulator.

elibosley commented 7 years ago

@dehli What's the status with this PR? If you get a chance to review this in the next few weeks, I'd be more than happy to update the code and make sure everything is good to go!

dehli commented 7 years ago

Hey @elibosley! It's on my backlog. I will get around to this either this weekend, or sometime next week! Hope you had a good week! 😄

elibosley commented 7 years ago

Awesome! Thanks, I had a great week! 😆

elibosley commented 6 years ago

Ugh so I'm finally getting around to this and having crazy setup issues with Ubuntu - hopefully I can figure out what's wrong with my configuration but I just figured I'd update you about it!

dehli commented 6 years ago

Sounds good! @elibosley Let me know if you need anything!

elibosley commented 6 years ago

@dehli Should I fork this repo to push my commit back up? I've updated the code a bit but I'm not sure how I should get it back into a PR

dehli commented 6 years ago

Hey @elibosley! You can just push directly to this branch and it will update the PR appropriately 😄