willox / auxtools

Rust library for low-level interfacing with BYOND's virtual machine. Includes a remote debugger for the BYOND DreamMaker language.
MIT License
28 stars 32 forks source link

Fix a warning in the linux build #66

Closed Cyberboss closed 1 year ago

Cyberboss commented 1 year ago
warning: getting the inner pointer of a temporary `CString`
  --> auxtools/src/version.rs:62:57
   |
62 |             let module = dlopen(CString::new(BYONDCORE).unwrap().as_ptr(), RTLD_LAZY);
   |                                 -------------------------------- ^^^^^^ this pointer will be invalid
   |                                 |
   |                                 this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime
   |
   = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned
   = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
   = note: `#[warn(temporary_cstring_as_ptr)]` on by default

warning: `auxtools` (lib) generated 1 warning
willox commented 1 year ago

this would not have been a problem in C++ :(