search

willpearse / phyloGenerator

Automated Phylogeny Generation for Ecologists
Other
15 stars 8 forks source link

Clarify requirements in README #11

Closed peterjc closed 11 years ago

peterjc commented 11 years ago

The read-me file currently says:

Install Python >=2.6; Numpy and SciPy for Python; Biopython >=2.5.

The currently version of Biopython is 1.60 (one, sixty), so something is wrong with that.

Also, having looked at the code it will not work under both Python 2 and 3 as it is, for instance you are using print statements. Therefore saying Python >=2.6 is potentially confusing as some users might try this under Python 3. I would suggest saying install Python 2.6 or 2.7 (since Python 2.7 is the final Python 2.x release).

willpearse commented 11 years ago

Hello,

Thanks very much for this. I'm sorry it's taken me so long to get back to you - somehow I missed all the issue-tracking for this.

These are all excellent points;I've made these changes, and am just about to push them to GitHub.

Thanks again for getting in touch,

Will

peterjc commented 11 years ago

Much better, but could you change "Biopython >=1.6" to read "Biopython >=1.60" instead (assuming you meant one dot sixty). This is a major.minor numbering scheme, not a decimal. The current release is Biopython 1.61 (one dot sixty-one), and there never was a 1.6 (one dot six). Thanks :)

willpearse commented 11 years ago

Thanks for this.

You're quite right, there was never a BioPython 1.6. I've corrected and pushed.

Phew! Looks like I need some kind of automated version control checking pipeline :p

Thanks again,

Will