search

willprice / python-omxplayer-wrapper

:tv: Control OMXPlayer, the Raspberry Pi media player, from Python
http://python-omxplayer-wrapper.readthedocs.io
GNU Lesser General Public License v3.0
253 stars 71 forks source link

Accept str path as input to OMXPlayer constructor #149

Closed willprice closed 5 years ago

willprice commented 5 years ago

Implemented in 9cb483264d5d01454254a5b506ff5ac08bd4c7dc

jehutting commented 5 years ago

_Still having an AttributeError in _run_omxplayer._

The change is not complete. It would make sense if in __init__ the self.load call uses the self._sourcein stead of source, and doing the same modification in load.

But wouldn't it better to set self._source = Path(source) in function load in stead of doing so in __init__?