willprice / python-omxplayer-wrapper

:tv: Control OMXPlayer, the Raspberry Pi media player, from Python

http://python-omxplayer-wrapper.readthedocs.io

GNU Lesser General Public License v3.0

253 stars 72 forks source link

Implement set_layer method #191

Closed JE-Random-Tech closed 4 years ago

JE-Random-Tech commented 4 years ago

Description

Implementation of the set_layer method.

Status: READY

Branch	PR
other_pr_production	[link]()
other_pr_master	[link]()

Todos

[ ] Tests
[ ] Documentation

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

codecov[bot] commented 4 years ago

Codecov Report

Merging #191 into master will increase coverage by 0.18%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   71.86%   72.05%   +0.18%     
==========================================
  Files           6        6              
  Lines         455      458       +3     
  Branches       25       25              
==========================================
+ Hits          327      330       +3     
  Misses        117      117              
  Partials       11       11

Impacted Files	Coverage Δ
omxplayer/player.py	`79.53% <100%> (+0.17%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1b361f...973efe3. Read the comment docs.

willprice commented 4 years ago

Thanks @JE-Random-Tech , Can you add an entry to the test_player_interface_commands parameterised tests like https://github.com/willprice/python-omxplayer-wrapper/blob/master/tests/unit/test_omxplayer.py#L70

JE-Random-Tech commented 4 years ago

@willprice Somehow the test for python 3.4 failed fetching http://deb.debian.org/debian/pool/main/p/python-pip/python-pip-whl_9.0.1-2_all.deb

JE-Random-Tech commented 4 years ago

Use layer instead of alpha.

Thanks, sorry missed that.

willprice commented 4 years ago

@willprice Somehow the test for python 3.4 failed fetching http://deb.debian.org/debian/pool/main/p/python-pip/python-pip-whl_9.0.1-2_all.deb

Yeah, seems like the travis config needs updating. Don't worry about it, I'll fix that on master once this is in. As long as python3.5+ pass we're good :+1:

JE-Random-Tech commented 4 years ago

Thanks.

willprice commented 4 years ago

Thanks for your contribution :)