search

willprice / python-omxplayer-wrapper

:tv: Control OMXPlayer, the Raspberry Pi media player, from Python
http://python-omxplayer-wrapper.readthedocs.io
GNU Lesser General Public License v3.0
253 stars 71 forks source link

Provide callbacks for actions like play, pause, stop, set_position, seek #49

Closed markkorput closed 7 years ago

markkorput commented 8 years ago

Kinda like #15, but easier to implement; the callbacks can simply be triggered by the corresponding methods in the OMXPlayer class and don't need to originate from the omxplayer process.

(I personally need this for the omxsync package at I'm writing at https://github.com/markkorput/pyOmxSync, which is inspired by the omxplayer-sync repo, but uses OMXPlayer as an interface to be more easily used in python projects).

willprice commented 8 years ago

Nice! Thanks for the contribution. I'll review it now. I'll also try and unbreak the tests

willprice commented 8 years ago

Tests are fixed so you're good to work off develop :)

willprice commented 7 years ago

Refactored some of Marks code and merged in #56