search

willprice / python-omxplayer-wrapper

:tv: Control OMXPlayer, the Raspberry Pi media player, from Python
http://python-omxplayer-wrapper.readthedocs.io
GNU Lesser General Public License v3.0
253 stars 71 forks source link

Add events to player methods #56

Closed willprice closed 7 years ago

willprice commented 7 years ago

Description

Adds events (contributed by @markkorput)

I've taken @markkorput branch and refactored the tests to use mocks, which makes them a bit more robust as we assert how many times the events are called rather than just checking they are called.

There's no docs on this functionality so this needs to be addressed before merging in.

Branch PR
feature-callbacks https://github.com/willprice/python-omxplayer-wrapper/pull/53

Todos

codecov-io commented 7 years ago

Current coverage is 82.98% (diff: 100%)

Merging #56 into develop will increase coverage by 3.43%

@@            develop        #56   diff @@
==========================================
  Files             3          3          
  Lines           225        241    +16   
  Methods           0          0          
  Messages          0          0          
  Branches         13         14     +1   
==========================================
+ Hits            179        200    +21   
+ Misses           40         35     -5   
  Partials          6          6

Powered by Codecov. Last update 81e4373...c96db1b