Fixup/renameinvalidate - Githubissues

willscott / go-nfs

golang NFSv3 server

Apache License 2.0

701 stars 76 forks source link

Closed willscott closed 10 months ago

willscott commented 10 months ago

simplify to remove inverse cache and directly invalidate handles

DUOLabs333 commented 10 months ago

This doesn't fix the problem of handles not being one-to-one/a new handle is returned every lookup.

willscott commented 10 months ago

Good point. I think we do need the complexity you suggested. I added an additional method to properly evict from the reverse index as well.

DUOLabs333 commented 10 months ago

Technically, the reverse cache must also hold the filesystems --- at which point, we should just use my PR.

willscott commented 10 months ago

does it?

if the handle matches, you can recover the filesystem from the forward cache
I'd prefer a single strong type rather than any for the value
we should be doing expiry so that the reverse cache doesn't grow in an unbounded way