search

willscott / grunt-jasmine-firefoxaddon

Run jasmine specs in a Firefox addon
Apache License 2.0
0 stars 1 forks source link

delete plugin after task runs #4

Closed agallant closed 9 years ago

agallant commented 9 years ago

Fix #2

@willscott, let me know if you think it's worth making this more configurable, for now this is simple and I think should satisfy the use case. I know you're busy for awhile so I may go ahead and merge and run with this in the near future regardless, but we can obviously revisit the issue any time you'd like.

willscott commented 9 years ago

Why buildff? What's wrong with build? On Aug 28, 2015 2:55 PM, "soycode" notifications@github.com wrote:

Fix #2 https://github.com/willscott/grunt-jasmine-firefoxaddon/issues/2

@willscott https://github.com/willscott, let me know if you think it's worth making this more configurable, for now this is simple and I think should satisfy the use case. I know you're busy for awhile so I may go ahead and merge and run with this in the near future regardless, but we can

obviously revisit the issue any time you'd like.

You can view, comment on, or merge this pull request online at:

https://github.com/willscott/grunt-jasmine-firefoxaddon/pull/4 Commit Summary

  • delete plugin after task runs

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/willscott/grunt-jasmine-firefoxaddon/pull/4.

agallant commented 9 years ago

I was using buildff in earlier stages when it didn't clean up and was colliding a bit with other things (like your grunt-jasmine-chromeapp). Now though it should be fine to use the same, so I went ahead and switched back.