search

willshersystems / ansible-sshd

Ansible role to configure the OpenSSH server daemon
https://galaxy.ansible.com/willshersystems/sshd
GNU Lesser General Public License v3.0
240 stars 136 forks source link

chore(linting): update variable names to include sshd_ prefix #246

Open mattwillsher opened 1 year ago

mattwillsher commented 1 year ago

Var names should be prefixed with role name to pass lint checks.

If no time to work on this check can be disabled for now.

Jakuje commented 1 year ago

This was disabled in 34be8e5ea372f25c4ed643340e8b9416eeae0738 (#248) if I see right so I would consider this done. I think we can not accommodate this lint requirement.

mattwillsher commented 1 year ago

The lint issue I've come across recently on a new role but try as I might I couldn't get the name to comply. I do believe that we should conform to this rule, though, as it's effectively a variable scoping challenge.

I'll leave this open for now as a reminder to myself.

spetrosi commented 1 week ago

In system roles, we deprecated old variables by printint a message to users who use those old variables, and then setting the correct variable name, see https://github.com/linux-system-roles/mssql/blob/main/tasks/main.yml#L12-L25 Then, maybe in a couple years, we can remove the deprecated variable completely.