search

willtownes / glmpca

GNU Lesser General Public License v3.0
92 stars 10 forks source link

Return factors and loadings as matrices instead of data frames #28

Open willtownes opened 3 years ago

willtownes commented 3 years ago

As pointed out by https://github.com/willtownes/scrna2019/issues/5 glmpca is returning factors as a data frame instead of a matrix (as the documentation claims), which causes downstream problems converting SingleCellExperiment objects to Seurat.

1) Expose an option to allow the user to decide whether to return matrix or data frame 2) Change the default to return matrices instead of data frames

The offending place in the code is here: https://github.com/willtownes/glmpca/blob/master/R/postprocess.R#L86

willtownes commented 3 years ago

Tagging @liuzhe93 so she can keep track of progress here.

liuzhe93 commented 3 years ago

Tagging @liuzhe93 so she can keep track of progress here.

ok, thanks a lot. Thanks for your kind help.