example of convert_date using was fixed

willtrnr / pyxlsb

Excel 2007+ Binary Workbook (xlsb) reader for Python

GNU Lesser General Public License v3.0

90 stars 21 forks source link

example of convert_date using was fixed #21

Closed IliyaZinoviev closed 4 years ago

IliyaZinoviev commented 4 years ago

I want you apply my changes for Readme file because it'll be usefull for other users. Thanks for your module!

willtrnr commented 4 years ago

This is actually already correct for the latest development version (master), covert_date used to be a module function, but with the 1904 handling it was moved to the Workbook object.

However, I do understand the confusion this could cause, I have now changed the default branch on GitHub so the default documentation that shows up is for the current pip version.