search

willtrnr / pyxlsb

Excel 2007+ Binary Workbook (xlsb) reader for Python
GNU Lesser General Public License v3.0
90 stars 21 forks source link

Add __version__ with the package version #22

Closed TomAugspurger closed 4 years ago

TomAugspurger commented 4 years ago

In https://github.com/pandas-dev/pandas/pull/29836, pandas is adding support for reading xlsb files, using pyxlsb as an engine. One difficulty we're having is that we can't check what version of pyxlsb is imported.

PEP 396 recommends a top-level __version__: https://www.python.org/dev/peps/pep-0396/. Could you add that to the package?

willtrnr commented 4 years ago

Sure, that's simple enough, I wasn't aware of PEP 396. I'll cut a new v1.0.6 with it so you can move forward.

willtrnr commented 4 years ago

v1.0.6 is up on PyPI