search

willtrnr / pyxlsb

Excel 2007+ Binary Workbook (xlsb) reader for Python
GNU Lesser General Public License v3.0
90 stars 21 forks source link

Add format recognition #26

Closed Zoynels closed 4 years ago

Zoynels commented 4 years ago

Add format recognition and convertation of datetime values

Zoynels commented 4 years ago

I think I rewrite code like you requested. Most of functions will calculate when request, but it will not be cached, so in future it could be optimised. But now it work fine.

Also I replace if workbook.convert_date() seconds to microseconds to more exact convertation.

willtrnr commented 4 years ago

I'm sorry this is a lot of comments, just letting you know you're doing a pretty good job on this :+1:

Zoynels commented 4 years ago

It is your project. So you have more wide view how it should develop in future.

willtrnr commented 4 years ago

@Zoynels I added a few last comments, after that I think we'll be able to merge this.

Afterwards I'll try to figure out exactly what form the API should have for 1.0.0. We only support very little of the Style structures, so I'll avoid exposing it too soon.