willtrnr / pyxlsb

Excel 2007+ Binary Workbook (xlsb) reader for Python
GNU Lesser General Public License v3.0
90 stars 21 forks source link

Sourcery refactored v1.0.x branch #41

Closed sourcery-ai[bot] closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Branch v1.0.x refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the v1.0.x branch, then run:

git fetch origin sourcery/v1.0.x
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.11%.

Quality metrics Before After Change
Complexity 7.70 ⭐ 7.69 ⭐ -0.01 👍
Method Length 42.12 ⭐ 41.67 ⭐ -0.45 👍
Working memory 8.90 🙂 8.91 🙂 0.01 👎
Quality 66.68% 🙂 66.79% 🙂 0.11% 👍
Other metrics Before After Change
Lines 181 178 -3
Changed files Quality Before Quality After Quality Change
pyxlsb/stringtable.py 93.82% ⭐ 93.86% ⭐ 0.04% 👍
pyxlsb/workbook.py 68.69% 🙂 68.76% 🙂 0.07% 👍
pyxlsb/worksheet.py 55.98% 🙂 55.81% 🙂 -0.17% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyxlsb/worksheet.py Worksheet.rows 25 😞 185 😞 16 ⛔ 29.44% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pyxlsb/worksheet.py Worksheet._parse 20 😞 126 😞 16 ⛔ 38.75% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pyxlsb/workbook.py Workbook._parse 7 ⭐ 154 😞 10 😞 55.60% 🙂 Try splitting into smaller methods. Extract out complex expressions
pyxlsb/workbook.py Workbook.get_sheet 5 ⭐ 159 😞 9 🙂 59.09% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!