search

willwerscheid / flashier

A faster and angrier package for EBMF.
https://willwerscheid.github.io/flashier/
Other
10 stars 12 forks source link

Error from init.fn.softImpute #78

Closed jean997 closed 1 year ago

jean997 commented 2 years ago

Using flash.add.greedy to add factors with init.fn = flashier:::init.fn.softImpute gives the error

Error in fitted.flash.fit(flash) : 
  Flash object does not have any factors
willwerscheid commented 2 years ago

need to rewrite init.fn.softImpute to handle flash objects with no factors. in that case do not call fitted.flash.fit but pass the data in directly

willwerscheid commented 2 years ago

also should be residuals.flash.fit not fitted.flash.fit!

willwerscheid commented 1 year ago

this appears to have been fixed in december 2022